Move from wpa_supplicant to NetworkManager and nmcli #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update WiFi module to use NetworkManager (nmcli) instead of wpa_supplicant - Update command handlers to work with NetworkManager - Add a new wifi-scan command to scan for available networks - Add a new migrate_to_networkmanager.sh script to help with migration - Update installation instructions and add NetworkManager to dependencies - Add migration information to README 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dbieber
commented
Apr 14, 2025
gonotego/settings/wifi.py
Outdated
| """Update NetworkManager connections for Go Note Go managed WiFi networks.""" | ||
| networks = get_networks() | ||
| filepath = '/etc/wpa_supplicant/wpa_supplicant.conf' | ||
| result = True |
gonotego/settings/wifi.py
Outdated
| # Read the existing config | ||
|
|
||
|
|
||
| def get_gonote_managed_connections(): |
gonotego/settings/wifi.py
Outdated
| with open(filepath, 'r') as f: | ||
| config = f.read() | ||
| result = subprocess.run( | ||
| ["nmcli", "-t", "-f", "NAME,TYPE", "connection", "show"], |
gonotego/settings/wifi.py
Outdated
| shell('sudo cp /tmp/wpa_supplicant.conf /etc/wpa_supplicant/wpa_supplicant.conf') | ||
| shell('rm /tmp/wpa_supplicant.conf') | ||
| cmd = [ | ||
| "sudo", "nmcli", "connection", "add", |
Owner
Author
There was a problem hiding this comment.
fix indentation (use 4 spaces for hanging indents like these)
gonotego/settings/wifi.py
Outdated
| return False | ||
|
|
||
|
|
||
| def add_open_connection(ssid): |
Owner
Author
There was a problem hiding this comment.
probably better to combine add_open_connection and add_wpa_connection since they're so similar
gonotego/settings/wifi.py
Outdated
| if ssid in available_networks: | ||
| # Try to connect to this network | ||
| subprocess.run( | ||
| ["nmcli", "connection", "up", "id", ssid], |
gonotego/settings/wifi.py
Outdated
| filepath = '/etc/wpa_supplicant/wpa_supplicant.conf' | ||
|
|
||
| if not os.path.exists(filepath): | ||
| if not subprocess.run(["test", "-f", filepath], capture_output=True).returncode == 0: |
Owner
Author
There was a problem hiding this comment.
os.path.exists is better than test -f, right?
gonotego/settings/wifi.py
Outdated
| try: | ||
| # Get all wifi connections | ||
| result = subprocess.run( | ||
| ["nmcli", "-t", "-f", "NAME,TYPE", "connection", "show"], |
gonotego/settings/wifi.py
Outdated
| for conn_name in wifi_connections: | ||
| # Get connection details | ||
| result = subprocess.run( | ||
| ["sudo", "nmcli", "--show-secrets", "connection", "show", conn_name], |
installation.md
Outdated
| sudo apt update | ||
| sudo apt upgrade | ||
| sudo apt install firefox-esr xvfb portaudio19-dev libatlas-base-dev redis-server espeak rustc python3-dev | ||
| sudo apt install firefox-esr xvfb portaudio19-dev libatlas-base-dev redis-server espeak rustc python3-dev network-manager |
Owner
Author
There was a problem hiding this comment.
Leave the installation.md as it was -- we'll update it in a separate pull request
…er function names, improve migrate function, and use os.path.exists
…ions, fix indentation to use 4 spaces for hanging indents, inline result=True
…wifi_connection function
…nections which doesn't filter connections
… add and modify operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Let's move away from wpa_supplicant in favor of NetworkManager and nmcli.
🤖 Generated with Claude Code