Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raises exception on duplicate key or duplicate value #12

Closed
wants to merge 2 commits into from

Conversation

@laertispappas
Copy link
Collaborator

laertispappas commented Nov 27, 2016

Do not allow for duplicate keys || duplicate values.

@laertispappas laertispappas force-pushed the laertispappas:lp/validate_input branch from a84ed51 to 524f678 Nov 27, 2016

* Your contribition here.

### 0.6.0 (27/11/2016)

This comment has been minimized.

Copy link
@dblock

dblock Nov 28, 2016

Owner

Since you're not making a release, undo this, leave versions alone.

This comment has been minimized.

Copy link
@laertispappas

laertispappas Nov 29, 2016

Author Collaborator

Sure.

@dblock

This comment has been minimized.

Copy link
Owner

dblock commented Nov 28, 2016

This is great. You can just remove old rubies and make the build green.

@laertispappas laertispappas force-pushed the laertispappas:lp/validate_input branch from 2800557 to e642b5f Nov 29, 2016
@laertispappas

This comment has been minimized.

Copy link
Collaborator Author

laertispappas commented Nov 29, 2016

Not sure why rb-x is failing

@dblock

This comment has been minimized.

Copy link
Owner

dblock commented Nov 30, 2016

Just remove rbx-2, it's a PITA. Sorry about that.

@@ -1,7 +1,11 @@
### 0.5.1 (Next)
### 0.6.1 (Next)

This comment has been minimized.

Copy link
@dblock

dblock Nov 30, 2016

Owner

Don't do this, leave versions alone here.

This comment has been minimized.

Copy link
@laertispappas

laertispappas Nov 30, 2016

Author Collaborator

Sure I will. Sorry for the misunderstanding. I've just started the open source involvement. Thanks for your feedback.

@laertispappas laertispappas force-pushed the laertispappas:lp/validate_input branch from e642b5f to f87722a Nov 30, 2016
@laertispappas

This comment has been minimized.

Copy link
Collaborator Author

laertispappas commented Dec 1, 2016

Removed rbx-2 from travis.yml. By the way what does PITA mean?

@dblock

This comment has been minimized.

Copy link
Owner

dblock commented Dec 4, 2016

PITA - Pain in the Ass :)

@dblock

This comment has been minimized.

Copy link
Owner

dblock commented Dec 5, 2016

Merged via 4b7c6eb.

@dblock dblock closed this Dec 5, 2016
@dblock

This comment has been minimized.

Copy link
Owner

dblock commented Dec 5, 2016

FYI I released 0.6.0 with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.