Skip to content
This repository has been archived by the owner on Oct 20, 2018. It is now read-only.

Make annotation probability configurable via a parameter #188

Closed
wants to merge 3 commits into from
Closed

Make annotation probability configurable via a parameter #188

wants to merge 3 commits into from

Conversation

sandroacoelho
Copy link
Contributor

A surface form is currently linked if its total score is > 0.5. This value should be configurable via a annotation threshold REST parameter (similar to support in the Lucene model). A lower value would show more annotations, a higher value would only show annotations the system is very confident about.

The relevant line in DBSpotter:

@jodaiber
Copy link
Member Author

@sandroacoelho Could you have a look at this, if you have time?

@sandroacoelho
Copy link
Contributor

Hi @jodaiber . Sure. I will do it.

@jodaiber
Copy link
Member Author

Great. I am not sure exactly how we should pass the parameter to the Spotter. It might be necessary to add a Spotter method extract(...) that also takes parameters. A good start would be to add a value

annotation_threshhold=0.5

to the model.properties file of the SpotlightModel and use it as the default value in DBSpotter.

Best,
Jo

@jodaiber
Copy link
Member Author

Any progress on this?

@sandroacoelho
Copy link
Contributor

Hi @jodaiber .
Sorry for the big delay. It's done!
Best,

@jodaiber
Copy link
Member Author

Hey @sandroacoelho,

this is a good start; however, I meant that the value should be changeable via a URL parameter (like ?support=10, e.g. ?entitycoverage=0.5).

Best,
Jo

@tgalery
Copy link
Member

tgalery commented Mar 12, 2015

Hi guys, is this PR still relevant ? It seems we can pass confidence as a rest param? Or do you want something that is distinct from confidence and only affects annotation probability ? I think there are some feature branches for that (somewhere).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants