Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
citationIri concerns #452
I have a few concerns about citationIri. It's trying to make a URL for the citation from its properties:
yes, for loops do not execute more than onece
This needs some investigation
I added this mostly to provide a stable ID
sounds good :)
not sure if that can be done directly at extraction time or with a post-processing step but we are open to all suggestions
I improved the citation IRI issue with most of the IDs I could find in the citation template documentations
The problem now is what to do with citations that have no ID or URL, these are for now skipped but I could create a UUID for those, what do you think?
Both cases doi and jstor check the field "doi". That's not wrong, as there are many DOI resolvers, see https://www.wikidata.org/wiki/Property:P356#P1630. But the second case is ineffectual, no?
Consider item 3 above. If a book or journal is cited in 1000 wikipedia articles, each will use the same ISBN or ISSN, and you'll generate the same citationIri. But if each cites a different chapter or article, it will have different title, pages, authors etc etc. You'll emit all these statements against the same citationIri, thus jumble them together.
Therefore all citations need their own URL, except those for which we can guarantee they cite individual items (arxiv, pmc, pubmed; DOI can reference either a book or an article so is not individual). Then we link this "own" node to the book or article, eg using
"Own URL" could mean: