Skip to content

Commit bba5389

Browse files
committed
issue #54: fix potential out-of-bounds heap read
1 parent 070ef6f commit bba5389

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: src/open_utils.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -1258,13 +1258,13 @@ int WavpackVerifySingleBlock (unsigned char *buffer, int verify_checksum)
12581258
#endif
12591259

12601260
if (meta_bc == 4) {
1261-
if (*dp++ != (csum & 0xff) || *dp++ != ((csum >> 8) & 0xff) || *dp++ != ((csum >> 16) & 0xff) || *dp++ != ((csum >> 24) & 0xff))
1261+
if (*dp != (csum & 0xff) || dp[1] != ((csum >> 8) & 0xff) || dp[2] != ((csum >> 16) & 0xff) || dp[3] != ((csum >> 24) & 0xff))
12621262
return FALSE;
12631263
}
12641264
else {
12651265
csum ^= csum >> 16;
12661266

1267-
if (*dp++ != (csum & 0xff) || *dp++ != ((csum >> 8) & 0xff))
1267+
if (*dp != (csum & 0xff) || dp[1] != ((csum >> 8) & 0xff))
12681268
return FALSE;
12691269
}
12701270

0 commit comments

Comments
 (0)