Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Element factories from Config to Graph/Collection LayoutFactory #1088

Closed
ChrizZz110 opened this issue Nov 20, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@ChrizZz110
Copy link
Contributor

commented Nov 20, 2018

follows #1086
blocked by #1086
blocks #1288

Element factories like EdgeFactory, VertexFactory etc. are stored in the GradoopConfig instance. Since there is no flexibility to use other Factories that extends the parent EPGMEdgeFactory classes, we should move them to the LayoutFactories. Both classes implement interfaces, that have three methods

  • getGraphHeadFactory()
  • getVertexFactory()
  • getEdgeFactory()

The Layout Factories know best, which element factories are needed to create the elements for this layout.

  1. Let BaseLayoutFactory extend ElementFactoryProvider
  2. Move three factories to implementations of BaseLayoutFactory and let them implement the three methods
  3. Change the passing of the element factories in GraphCollectionFactory and LogicalGraphFactory from config to the layoutFactories.
  4. Replace all occurences of config.getXXXFactory() to graph.getXXXFactory or collection.getXXFactory()

! Also refactor existing ElementFactories with a default behaviour inside the interfaces!

@ChrizZz110 ChrizZz110 changed the title Move Element factories from Config to Graph/Collection Factory Move Element factories from Config to Graph/Collection LayoutFactory Nov 26, 2018

@ChrizZz110

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2018

Will be done by @0x002A.

@ChrizZz110 ChrizZz110 self-assigned this Dec 6, 2018

@ChrizZz110

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

Closed since there is no need for it atm.

@ChrizZz110 ChrizZz110 closed this Jan 3, 2019

@ChrizZz110 ChrizZz110 reopened this Jun 3, 2019

@ChrizZz110

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Think this is needed now ...

timo95 added a commit to timo95/gradoop that referenced this issue Jun 5, 2019

timo95 added a commit to timo95/gradoop that referenced this issue Jun 6, 2019

@galpha galpha referenced this issue Jun 25, 2019

Open

[Epic] release version 0.5.0 #1319

3 of 7 tasks complete

@galpha galpha added this to the release 0.5.0 milestone Jun 25, 2019

timo95 added a commit to timo95/gradoop that referenced this issue Jun 26, 2019

ChrizZz110 added a commit to timo95/gradoop that referenced this issue Jul 3, 2019

ChrizZz110 added a commit to timo95/gradoop that referenced this issue Jul 3, 2019

ChrizZz110 added a commit that referenced this issue Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.