New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default implementation for Operator.getName. #1163

Closed
p-f opened this Issue Jan 22, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@p-f
Copy link
Collaborator

p-f commented Jan 22, 2019

The getName method of the org.gradoop.flink.model.api.operators.Operator interface is implemented in almost every function as

this.getClass().getName();

or something that is semantically equivalent. I think we should replace it with a default implementation on that interface. This way we could

  1. Remove duplicate code.
  2. Make it easier to change, in case somebody wants to use the operator names in the future. (They are currently of no use, afaik.)

Flink depends on Java 8, so default methods will be supported everywhere.

@p-f

This comment has been minimized.

Copy link
Collaborator Author

p-f commented Jan 22, 2019

Will open a PR when #1162 is merged. (To avoid conflicts.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment