Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyValue FLAG_LARGE does not use the last bit #1176

Closed
timo95 opened this issue Mar 5, 2019 · 1 comment · Fixed by #1216
Closed

PropertyValue FLAG_LARGE does not use the last bit #1176

timo95 opened this issue Mar 5, 2019 · 1 comment · Fixed by #1216

Comments

@timo95
Copy link
Contributor

timo95 commented Mar 5, 2019

The current flag is 0x10 = 0b0001_0000.
It should optimally be 0x80 = 0b1000_0000 = -128 so that further types don't have to avoid one bit in the middle.

Accumulo and HBase stores might have data using the old flag. This would have to be noted as incompatible or converted to the new flag.
@timo95
Copy link
Contributor Author

timo95 commented Apr 16, 2019

There doesn't seem to be any DataSink using the flag to write data. I will provide a PR.

@timo95 timo95 mentioned this issue Apr 16, 2019
Merged
galpha pushed a commit that referenced this issue Apr 17, 2019
@timo95
[1176] Use last bit for FLAG_LARGE (#1216)
20ea3e7 
fixes #1176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[1176] Use highest bit for FLAG_LARGE timo95/gradoop
1 participant
@timo95