Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PropertyValue type byte constants to be implemented by enum #1184

Closed
Rascat opened this issue Mar 19, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Rascat
Copy link
Contributor

commented Mar 19, 2019

As of now, the type byte constants in PropertyValue (TYPE_LIST, TYPE_MAP, ...) are implemented as simple byte constants.

I propose creating a new enum type TYPE, which effectively merges the enum TypeString in MetaData with the bit constansts in PropetyValue, since they both represent a type.
The newly created enum could reside in an own file somewhere in gradoop-common, possibly in the properties directory.

@ChrizZz110

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Please have a look at the HBase and Accumulo Implementation before. They use this Byte to define the type of the properties. It will be great if we can use already stored graphs in HBase and Accumulo as before, without rewriting the data.

Rascat added a commit to Rascat/gradoop that referenced this issue Mar 21, 2019

[dbs-leipzig#1184] Add enum type Type
* Add enum type that encapsulates representations for all supported
PropertyValue types.

Rascat added a commit to Rascat/gradoop that referenced this issue May 3, 2019

[dbs-leipzig#1184] Add enum type Type
* Add enum type that encapsulates representations for all supported
PropertyValue types.

Rascat added a commit to Rascat/gradoop that referenced this issue May 3, 2019

Merge branch 'dbs-leipzig#1184-refactor-type-byte-constants' of githu…
…b.com:Rascat/gradoop into dbs-leipzig#1184-refactor-type-byte-constants

Rascat added a commit to Rascat/gradoop that referenced this issue May 3, 2019

Rascat added a commit to Rascat/gradoop that referenced this issue May 6, 2019

[dbs-leipzig#1184] Rename enum Type methods
* rename asByte to getTypeByte
* rename asString to tostring

galpha added a commit to Rascat/gradoop that referenced this issue May 6, 2019

galpha added a commit to Rascat/gradoop that referenced this issue May 7, 2019

@galpha galpha closed this in #1251 May 7, 2019

galpha added a commit that referenced this issue May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.