Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TestNG #1212

Closed
Rascat opened this issue Apr 12, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Rascat
Copy link
Contributor

commented Apr 12, 2019

TestNG is a testing framework which offers much more features and a more flexible API than JUnit4.
It would enable us to write concise parameterized tests (Data-driven testing) and define testsuites which are appropriate for a given development stage (fast tests when in development, slow/all tests in CI).
JUnit5 offers similar features but, most of them are marked 'experimental' which makes switching to JU5 a harder decision.

A migration of the test base to TestNG could be the next step.

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 12, 2019

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 15, 2019

Lucas
[dbs-leipzig#1212] Configure surefire plugin
* Junit tests are run with JUnit4
* TestNG tests are run with TestNG
@Rascat

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Screenshot_2019-04-15 TestNG reports

testng reporter output for GradoopIdTest

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 15, 2019

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 15, 2019

Lucas
[dbs-leipzig#1212] Introduce TestNG
* Junit tests are run with JUnit4
* TestNG tests are run with TestNG
* Suppress TestNG XMLReporter error log

@Rascat Rascat changed the title Introduce TestNG WIP: Introduce TestNG Apr 18, 2019

@Rascat Rascat changed the title WIP: Introduce TestNG Introduce TestNG Apr 18, 2019

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 18, 2019

Lucas
[dbs-leipzig#1212] Refactor PropertyValueTest
* Test class now uses TestNG
* Use parameterized tests where possible

@ChrizZz110 ChrizZz110 added the testing label Apr 24, 2019

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 26, 2019

Lucas
[dbs-leipzig#1212] Introduce TestNG
* Junit tests are run with JUnit4
* TestNG tests are run with TestNG
* Suppress TestNG XMLReporter error log

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 26, 2019

Lucas
[dbs-leipzig#1212] Refactor PropertyValueTest
* Test class now uses TestNG
* Use parameterized tests where possible

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 26, 2019

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 26, 2019

Rascat pushed a commit to Rascat/gradoop that referenced this issue Apr 26, 2019

Rascat added a commit to Rascat/gradoop that referenced this issue Apr 29, 2019

[dbs-leipzig#1212] Migrate gradoop-common: junit to testng
* replace junit assertions with testng counterparts
* refactor parameterized tests
* simplify assertions where possible
* add gradoop-common-testng.xml in order to define test suite
* configure surefire to use newly added testng.xml

Rascat added a commit to Rascat/gradoop that referenced this issue May 13, 2019

[dbs-leipzig#1212] Add null to array of supported data types
* combine testCreate and testCreateWithNull
* replace assertThat with assertEquals
* Test if PropertyValue type conversions raise UnsupportedOperationException
* refactor PropertyValue.get() to prevent NullPointerException

Rascat added a commit to Rascat/gradoop that referenced this issue May 13, 2019

Rascat added a commit to Rascat/gradoop that referenced this issue May 20, 2019

@galpha galpha closed this in 2cb03a3 Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.