Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ApplySubgraph #1233

Closed
timo95 opened this issue Apr 23, 2019 · 1 comment · Fixed by #1264

Comments

@timo95
Copy link
Contributor

commented Apr 23, 2019

  • Old GraphHeads should be retained
  • A new operator interface based on BaseGraphCollection should be used
  • Subgraph.Strategy should be used

Maybe we should reconsider our approach to operators on graph collections. We have multiple operators for logical graphs and graph collections, whose implementation is very similar (Aggregation, Transformation, etc.). Logical graphs could be seen as special case of graph collection with only one graph head.

@ChrizZz110

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Related to #233

timo95 added a commit to timo95/gradoop that referenced this issue May 14, 2019
timo95 added a commit to timo95/gradoop that referenced this issue Jun 4, 2019
timo95 added a commit to timo95/gradoop that referenced this issue Jun 11, 2019
timo95 added a commit to timo95/gradoop that referenced this issue Jun 11, 2019
@galpha galpha referenced this issue Jun 25, 2019
7 of 7 tasks complete

@galpha galpha added this to the release 0.5.0 milestone Jun 25, 2019

ChrizZz110 added a commit that referenced this issue Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.