Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch naming in implementation and interface classes of graph elements #1310

Closed
galpha opened this issue Jun 12, 2019 · 0 comments
Closed

Switch naming in implementation and interface classes of graph elements #1310

galpha opened this issue Jun 12, 2019 · 0 comments
Milestone

Comments

@galpha
Copy link
Contributor

@galpha galpha commented Jun 12, 2019

In order to support future additions to Gradoop such as TPGM Model or EPGM based on Table API, we should provide a more simple naming considering implementation and interface classes of our graph elements.

E.g. our Vertex class extends an EPGMVertex interface. To simplify future usage of our API we should switch the names of implementation and interface class. This way future graph elements like TableVertex or TPGMVertex extend a common base class called Vertex.

galpha added a commit to galpha/gradoop that referenced this issue Jun 12, 2019
* minor changes in documentation
* switched naming in element interfaces and implementations
* switched naming in element factory interfaces and implementations
* increased max line width to 110 characters + added change in gradoop-checkstyle.xml
galpha added a commit to galpha/gradoop that referenced this issue Jun 12, 2019
* minor changes in documentation
* switched naming in element interfaces and implementations
* switched naming in element factory interfaces and implementations
* increased max line width to 110 characters + added change in gradoop-checkstyle.xml
galpha added a commit to galpha/gradoop that referenced this issue Jun 12, 2019
* resolved automatic merge conflict
galpha added a commit to galpha/gradoop that referenced this issue Jun 20, 2019
* addressed pr comments
galpha added a commit to galpha/gradoop that referenced this issue Jun 24, 2019
* fixed conflict
galpha added a commit to galpha/gradoop that referenced this issue Jun 25, 2019
* addressed pr comments
galpha added a commit to galpha/gradoop that referenced this issue Jun 25, 2019
* additional documentation change
@galpha galpha added this to the release 0.5.0 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant