Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyValue does not implement Comparable correctly. #1314

Closed
p-f opened this issue Jun 12, 2019 · 0 comments

Comments

@p-f
Copy link
Collaborator

commented Jun 12, 2019

The Javadoc description of the Comparable interface states that implementing the interface imposes a total ordering on the implementing class. However the current implementation is not a total ordering, since 2 PropertyValues with a different type may not be comparable.
We should either remove that interface from PropertyValue or provide an implementation that works for any two PropertyValues.

related #1311
somewhat related #463

p-f added a commit to p-f/gradoop that referenced this issue Jun 14, 2019

p-f added a commit to p-f/gradoop that referenced this issue Jun 18, 2019

@galpha galpha added this to the release 0.5.0 milestone Jun 25, 2019

@galpha galpha referenced this issue Jun 25, 2019
7 of 7 tasks complete

p-f added a commit to p-f/gradoop that referenced this issue Jun 25, 2019

[dbs-leipzig#1314] Rename kind to category.
- make Comparator serializable
- remove comparison to null
- add tests for that case

timo95 added a commit to timo95/gradoop that referenced this issue Aug 6, 2019

timo95 added a commit to timo95/gradoop that referenced this issue Aug 6, 2019

ChrizZz110 added a commit that referenced this issue Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.