Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Simple DOT Output Format when a string value has quotes #1350

Closed
ChrizZz110 opened this issue Aug 8, 2019 · 1 comment · Fixed by #1360

Comments

@ChrizZz110
Copy link
Contributor

commented Aug 8, 2019

When a property is a String and has quotes inside the text, the dot can not be parsed.
Example vertex output by simple dot sink:

v5d4ac662927f500defd2a9dd5d4c21e6927f505853402793 [label="QuestionPost",Title="In the books Wojo's Weapons, why was Wojo occasionally known to say "I'm too lazy!" when asked why he didn't play 1. d4 instead of 1. Nf3?"];

The \n character should be escaped.

@Rascat

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

I'll look into this ☝️

Rascat added a commit to Rascat/gradoop that referenced this issue Aug 13, 2019
Rascat added a commit to Rascat/gradoop that referenced this issue Aug 13, 2019
Rascat added a commit to Rascat/gradoop that referenced this issue Aug 14, 2019
[dbs-leipzig#1350] Escape chars in DotFileFormatSimple
- introduce test which checks escaping for DotFileFormatSimple
- reformat string declarations
- remove DotFormat param from checkWriteOutput(). We dont need that since
we escape chars for both formats

fixes dbs-leipzig#1350
Rascat added a commit to Rascat/gradoop that referenced this issue Aug 15, 2019
[dbs-leipzig#1350] Shorten test input
- remove spurious semicolon
Rascat added a commit to Rascat/gradoop that referenced this issue Aug 27, 2019
Rascat added a commit to Rascat/gradoop that referenced this issue Aug 30, 2019

@galpha galpha closed this in #1360 Sep 4, 2019

galpha added a commit that referenced this issue Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.