Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVDataSink/Source don't support PropertyValue Null Type #877

Closed
timo95 opened this issue Jul 11, 2018 · 4 comments
Closed

CSVDataSink/Source don't support PropertyValue Null Type #877

timo95 opened this issue Jul 11, 2018 · 4 comments

Comments

@timo95
Copy link
Contributor

timo95 commented Jul 11, 2018

No description provided.

@timo95 timo95 changed the title CSVDataSink/Source don't support Null Type CSVDataSink/Source don't support PropertyValue Null Type Jul 11, 2018
@2start
Copy link
Contributor

2start commented Jul 23, 2018

I'll take a look at it.

@2start
Copy link
Contributor

2start commented Jul 23, 2018

I propose the following design:

metadata.csv

v;Person;flag: null

The property flag has the type null.

vertices.csv

1. 000000000000000000000000;Person;null
2. 000000000000000000000001;Person;

For the first vertex the only valid value of type null is set, the value null. Therefore, the property flag is defined for the first person.
For the second person, on the other hand, the property flag does not exist. This is consistent with the other data types.

@timo95
Copy link
Contributor Author

timo95 commented Jul 23, 2018

I think you only have to add the type and typeString to the csv MetaDataParser and change the appropiate tests. The used PropertyValue toString() method already returns the value string "null" for null properties.

That would result in your proposed design.

@2start
Copy link
Contributor

2start commented Jul 24, 2018

okay thanks I'll try that

2start added a commit to 2start/gradoop that referenced this issue Jul 26, 2018
2start added a commit to 2start/gradoop that referenced this issue Jul 26, 2018
2start added a commit to 2start/gradoop that referenced this issue Jul 26, 2018
2start added a commit to 2start/gradoop that referenced this issue Jul 26, 2018
2start added a commit to 2start/gradoop that referenced this issue Jul 30, 2018
2start added a commit to 2start/gradoop that referenced this issue Jul 30, 2018
@galpha galpha closed this as completed in 1ede21b Jul 31, 2018
ChrizZz110 pushed a commit that referenced this issue Aug 24, 2018
### Release 0.4.1

* [#877] added support for property value null (#908)

fixes #877

* [#856] property pushdown hbase (#906)

fixes #856

* [#864] Change examples to use csv (#905)

fixes #864

* [#494] Add Set support to PropertyValue (#916)

fixes #494

* [#888] Minor changes to Tuple-related functions. (#912)

fixes #888

* [#779] Add code coverage for Gradoop (#914)

fixes #779

* [#702] Add support for graphs without edges to TLFDataSource (#921)

fixes #702

* [#909] Remove Flink dependency for store instance (#918)

fixes #909

* [#876] added print for logical graph and graph collection (#913)

fixes #876

* [#857] logical predicate chaining hbase (#920)

fixes #857

* [#926] added argLine to maven properties (fix ide testing bug) (#929)

fixes #926

* [#794] include new benchmark classes (#904)

fixes #794

* [#312] example program for aggregation (#925)

fixes #312

* [#901] Add SamplingConstants, AggregationConstants (#934)

fixed #901

* [#935] Add tests for containment functions (#941)

fixes #935

* [#900] Refactor sampling tests. (#907)

fixes #900

* [#936] Generalized RollUp and DrillDown (#939)

fixes #936

* [#947] Fix PageRank wrapper and add a test. (#949)

fixes #947

* [#942] graph density computation for sampling evaluation (#946)

fixes #942

* [#954] prepare minor release (#955)

fixes #954
0x002A pushed a commit to ChrizZz110/gradoop that referenced this issue Feb 19, 2019
0x002A pushed a commit to ChrizZz110/gradoop that referenced this issue Feb 19, 2019
### Release 0.4.1

* [dbs-leipzig#877] added support for property value null (dbs-leipzig#908)

fixes dbs-leipzig#877

* [dbs-leipzig#856] property pushdown hbase (dbs-leipzig#906)

fixes dbs-leipzig#856

* [dbs-leipzig#864] Change examples to use csv (dbs-leipzig#905)

fixes dbs-leipzig#864

* [dbs-leipzig#494] Add Set support to PropertyValue (dbs-leipzig#916)

fixes dbs-leipzig#494

* [dbs-leipzig#888] Minor changes to Tuple-related functions. (dbs-leipzig#912)

fixes dbs-leipzig#888

* [dbs-leipzig#779] Add code coverage for Gradoop (dbs-leipzig#914)

fixes dbs-leipzig#779

* [dbs-leipzig#702] Add support for graphs without edges to TLFDataSource (dbs-leipzig#921)

fixes dbs-leipzig#702

* [dbs-leipzig#909] Remove Flink dependency for store instance (dbs-leipzig#918)

fixes dbs-leipzig#909

* [dbs-leipzig#876] added print for logical graph and graph collection (dbs-leipzig#913)

fixes dbs-leipzig#876

* [dbs-leipzig#857] logical predicate chaining hbase (dbs-leipzig#920)

fixes dbs-leipzig#857

* [dbs-leipzig#926] added argLine to maven properties (fix ide testing bug) (dbs-leipzig#929)

fixes dbs-leipzig#926

* [dbs-leipzig#794] include new benchmark classes (dbs-leipzig#904)

fixes dbs-leipzig#794

* [dbs-leipzig#312] example program for aggregation (dbs-leipzig#925)

fixes dbs-leipzig#312

* [dbs-leipzig#901] Add SamplingConstants, AggregationConstants (dbs-leipzig#934)

fixed dbs-leipzig#901

* [dbs-leipzig#935] Add tests for containment functions (dbs-leipzig#941)

fixes dbs-leipzig#935

* [dbs-leipzig#900] Refactor sampling tests. (dbs-leipzig#907)

fixes dbs-leipzig#900

* [dbs-leipzig#936] Generalized RollUp and DrillDown (dbs-leipzig#939)

fixes dbs-leipzig#936

* [dbs-leipzig#947] Fix PageRank wrapper and add a test. (dbs-leipzig#949)

fixes dbs-leipzig#947

* [dbs-leipzig#942] graph density computation for sampling evaluation (dbs-leipzig#946)

fixes dbs-leipzig#942

* [dbs-leipzig#954] prepare minor release (dbs-leipzig#955)

fixes dbs-leipzig#954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants