New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated Functionality in flink.algorithms #972

Closed
aehm03 opened this Issue Aug 31, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@aehm03
Contributor

aehm03 commented Aug 31, 2018

The classes ToGellyVertexWithIdValue in algorithms.btgs.functions and VertexToGellyVertexWithGradoopId in algorithms.gelly.functions fullfill the same functionality. I am not sure if this is intended because only functions from subpackages are used. However a refactor into a dedicated package for transformations to and from gelly could solves this.

@p-f

This comment has been minimized.

Show comment
Hide comment
@p-f

p-f Aug 31, 2018

Collaborator

Transformations to gelly already have a dedicated package (algorithms.gelly).
The function in btgs.functions can be removed

Collaborator

p-f commented Aug 31, 2018

Transformations to gelly already have a dedicated package (algorithms.gelly).
The function in btgs.functions can be removed

Rascat added a commit to Rascat/gradoop that referenced this issue Sep 6, 2018

[#972] remove class ToGellyVertexWithIdValue
Remove class because functionality is already provided by
gelly.functions.VertexToGellyVertexWithGradoopId.
Replace usage in class BusinessTransactionGraphs.

@ChrizZz110 ChrizZz110 closed this in #984 Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment