Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1011] Remaining data-integration operators #1123

Merged
merged 50 commits into from Feb 14, 2019

Conversation

Projects
None yet
4 participants
@merando
Copy link
Contributor

merando commented Dec 10, 2018

This PR is related to all the remaining transformation operators issues: #1011 #1012 #1013 #1014

Thx for @p-f s collaboration!

merando and others added some commits Oct 8, 2018

Merge pull request #1 from p-f/1011_vertex_to_edge_patches
[#1011] Fix unit test and graph containment issue.
Merge pull request #2 from p-f/1011_vertex_to_edge_patches
[#1011]  Corretions and tests for EdgeToVertex and PropagatePropertyToNeighbor.
Merge pull request #3 from p-f/1011_vertex_to_edge_patches
[#1011] Update to latest develop state.
@merando

This comment has been minimized.

Copy link
Contributor Author

merando commented Dec 17, 2018

@p-f be so kind and provide a PR at my repo in regard to the demanded changes.

p-f and others added some commits Dec 17, 2018

@ChrizZz110 ChrizZz110 changed the title [#1011] vertex to edge operator [#1011] Remaining data-integration operators Jan 7, 2019

p-f and others added some commits Jan 7, 2019

@ChrizZz110

This comment has been minimized.

Copy link
Contributor

ChrizZz110 commented Jan 8, 2019

OK, I closed the resolved issues and let the not implemented ones open ... please double check. @galpha maybe you will do the second review.

p-f and others added some commits Jan 8, 2019

@p-f

This comment has been minimized.

Copy link
Collaborator

p-f commented Jan 8, 2019

Unless I missed anything, there was only one comment left. I changed it.

Edit: Still some small things missing.

@p-f

This comment has been minimized.

Copy link
Collaborator

p-f commented Jan 18, 2019

I am still unsure how to handle the issue with the EdgeDirection enum.
Should on of those be renamed? Unifying both would not be correct, imo.

@ChrizZz110

This comment has been minimized.

Copy link
Contributor

ChrizZz110 commented Jan 18, 2019

p-f and others added some commits Jan 21, 2019

p-f and others added some commits Jan 21, 2019

@galpha

galpha approved these changes Feb 14, 2019

Copy link
Contributor

galpha left a comment

LGTM

@galpha galpha merged commit f113b24 into dbs-leipzig:develop Feb 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.