Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1173] Refactor license and notice files #1175

Merged

Conversation

@Rascat
Copy link
Contributor

@Rascat Rascat commented Mar 5, 2019

LOG:

  • Create NOTICE file for hbase module
  • Add NOTICE file for flink module
  • Add NOTICE file for examples module
  • Add NOTICE file for common module
  • Add antlr4 license
  • Add commons-cli to gradoop-examples NOTICE
  • propagate NOTICE and LICENSE files up to root
Rascat added 3 commits Mar 5, 2019
* refactors files according to the Apache standard

LOG:
* Create NOTICE file for hbase module
* Add NOTICE file for flink module
* Add NOTICE file for examples module
* Add NOTICE file for common module
* Add antlr4 license
* Add commons-cli to gradoop-examples NOTICE
* propagate NOTICE and LICENSE files up to root
* remove apache license part from root LICENSE
@Rascat Rascat marked this pull request as ready for review Mar 8, 2019
Copy link
Contributor

@galpha galpha left a comment

Changes for the package gradoop-data-integration is missing.

In addition you can add all used third party dependencies to the licenses-binary folder. Each License should be stored as LICENSE.XXX. All licences of dependencies where we used sources directly should be stored in a new licences directory (see list below).

  • HBaseWD (ALv2) in Gradoop-Hbase (RowKeyDistributor)
  • MongoDB - BSON Objectid in Gradoop-Common (GradoopId)
@Rascat
Copy link
Contributor Author

@Rascat Rascat commented Mar 15, 2019

I did not add a NOTICE or licenses directory the gradoop-data-integration module, because the pom does not define any third party dependencies.
I have added the licenses for the products where the source code was used directly.
I don't think adding ASLv2.0 licenses to the licenses-binary folder is necessary, since Gradoop itself is licensed as such.

* Add licenses for MongoDB and HBaseWD
* Rename licenses to LICENSE.XXX
@galpha
galpha approved these changes Mar 15, 2019
Copy link
Contributor

@galpha galpha left a comment

LGTM - Good baseline.

@galpha galpha merged commit b7569e7 into dbs-leipzig:develop Mar 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants