Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1200] sampling cleanup #1210

Merged
merged 5 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@galpha
Copy link
Contributor

galpha commented Apr 8, 2019

  • added sampling constants class for string constants used by all sampling algorithms
  • added random walk sampling to sampling benchmark
  • moved sampling statistics to statistics package (same with runners)
  • fixed typos
  • removed string output in CSVDataSinkTest

fixes #1200

galpha added some commits Apr 8, 2019

[#1200] refactored constants handling
- minor changes
- fixed typos
[#1200]
- added random walk sampling to benchmark class
- moved all statistics of sampling eval to statistics package
- moved all runner of statistics of sampling eval to statistics runner package
- fixed typos
- removed string output in CSVDataSinkTest

@galpha galpha changed the title #1200 sampling refactoring [#1200] sampling refactoring Apr 8, 2019

@galpha galpha changed the title [#1200] sampling refactoring [#1200] sampling cleanup Apr 8, 2019

galpha added some commits Apr 9, 2019

@ChrizZz110
Copy link
Contributor

ChrizZz110 left a comment

LGTM

@galpha galpha merged commit 60e4b2b into dbs-leipzig:develop Apr 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.