Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1184] Refactor type byte constants #1251

Merged

Conversation

Projects
None yet
3 participants
@Rascat
Copy link
Contributor

commented May 3, 2019

  • Add enum class Type which handles byte and string representations of supported types
  • Refactor uses of PropertyValue.X and MetaData.Y to use enum types

fixes #1184

Rascat added some commits Mar 21, 2019

[#1184] Add enum type Type
* Add enum type that encapsulates representations for all supported
PropertyValue types.
[#1184] Add enum type Type
* Add enum type that encapsulates representations for all supported
PropertyValue types.

@Rascat Rascat changed the title #1184 refactor type byte constants [#1184] efactor type byte constants May 3, 2019

@Rascat Rascat changed the title [#1184] efactor type byte constants [#1184] Refactor type byte constants May 3, 2019

[#1184] Rename enum Type methods
* rename asByte to getTypeByte
* rename asString to tostring
@ChrizZz110
Copy link
Contributor

left a comment

lgtm

@galpha

galpha approved these changes May 6, 2019

Copy link
Contributor

left a comment

LGTM

galpha added some commits May 6, 2019

@galpha galpha merged commit 591c9d9 into dbs-leipzig:develop May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.