Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1280] Fix some inspection warnings #1282

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
4 participants
@timo95
Copy link
Contributor

commented May 21, 2019

Fixes #1280.

@ChrizZz110
Copy link
Contributor

left a comment

LGTM

@@ -419,7 +419,7 @@ public Edge getEdgeByVariable(String variable) {
Collection<Edge> successors =
getEdgesBySourceVertexId(getEdgeById(edgeId).getTargetVertexId());
return successors != null ?
Lists.newArrayList(successors) : Lists.<Edge>newArrayList();
Lists.newArrayList(successors) : Lists.newArrayList();

This comment has been minimized.

Copy link
@p-f

p-f May 23, 2019

Collaborator

Replace those with new ArrayList<>().

@@ -405,7 +405,7 @@ public Edge getEdgeByVariable(String variable) {
Collection<Edge> predecessors =
getEdgesByTargetVertexId(getEdgeById(edgeId).getSourceVertexId());
return predecessors != null ?
Lists.newArrayList(predecessors) : Lists.<Edge>newArrayList();
Lists.newArrayList(predecessors) : Lists.newArrayList();

This comment has been minimized.

Copy link
@p-f

p-f May 23, 2019

Collaborator

Replace those calls with just a new ArrayList<>() constructor.

@galpha galpha merged commit b77d243 into dbs-leipzig:develop May 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timo95 timo95 deleted the timo95:1280-inspections branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.