Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1088] Move Element factories from Config to BaseFactory #1301

Merged
merged 13 commits into from Jul 3, 2019

Conversation

Projects
None yet
4 participants
@timo95
Copy link
Contributor

commented Jun 5, 2019

Fixes #1088.

timo95 added some commits Jun 5, 2019

@timo95 timo95 force-pushed the timo95:1088-factory branch from c8bdbd1 to 219e52b Jun 6, 2019

timo95 and others added some commits Jun 7, 2019

@ChrizZz110
Copy link
Contributor

left a comment

LGTM

@ChrizZz110 ChrizZz110 requested a review from galpha Jun 27, 2019

@ChrizZz110

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@galpha I think a second review will be necessary here

@p-f

p-f approved these changes Jul 2, 2019

@galpha

galpha approved these changes Jul 3, 2019

Copy link
Contributor

left a comment

LGTM - only one minor change requested

ChrizZz110 added some commits Jul 3, 2019

@ChrizZz110 ChrizZz110 merged commit 3479c1f into dbs-leipzig:develop Jul 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timo95 timo95 deleted the timo95:1088-factory branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.