Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1302] Add BaseGraph as generic type to BaseGraphCollection #1304

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@timo95
Copy link
Contributor

commented Jun 6, 2019

Fixes #1302.

@galpha

galpha approved these changes Jun 6, 2019

Copy link
Contributor

left a comment

LGTM

@galpha

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

PR #1267 should be merged before this PR to avoid merge conflicts.

@timo95

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

I will need to update the remaining PR anyway, whether thats this one or #1267 doesn't matter.

@galpha

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

You're right. Review of #1267 is done. I will merge this now.

@galpha galpha merged commit a48fcbc into dbs-leipzig:develop Jun 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timo95 timo95 deleted the timo95:1302-generic branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.