Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1310] Simplified naming of Graph, Element and Factory APIs #1315

Merged
merged 8 commits into from Jun 25, 2019

Conversation

@galpha
Copy link
Contributor

@galpha galpha commented Jun 12, 2019

Switched naming of interfaces and implementations of the following classes:

  • EPGMVertex <-> Vertex
  • EPGMEdge <-> Edge
  • EPGMGraphHead <-> GraphHead
  • EPGMElement <-> Element
  • EPGMGraphElement <-> GraphElement
  • EPGM*Factory <-> *Factory (e.g EPGMEdgeFactory <-> EdgeFactory)
    and several more

Extended Line limit to 110 characters.

fixes #1310

galpha added 3 commits Jun 12, 2019
* minor changes in documentation
* switched naming in element interfaces and implementations
* switched naming in element factory interfaces and implementations
* increased max line width to 110 characters + added change in gradoop-checkstyle.xml
* resolved automatic merge conflict
@galpha galpha changed the title [#1310] Simplified naming of Graph, Element and Factory API [#1310] Simplified naming of Graph, Element and Factory APIs Jun 12, 2019
Copy link
Contributor

@timo95 timo95 left a comment

Your forgot one class and a few functions, but the rest is only JavaDoc. I didn't look at everything.

@galpha
Copy link
Contributor Author

@galpha galpha commented Jun 13, 2019

Your forgot one class and a few functions, but the rest is only JavaDoc. I didn't look at everything.

Thx a lot! I was iterating over the changes of my PR and already fixed some of your commented lines. You're absolutely right about the IdentifiableComparator. I will use the rest of your comments as additional guidance during the rest of my iteration through the changed code.

galpha added 2 commits Jun 25, 2019
* addressed pr comments
* additional documentation change
Copy link
Contributor

@ChrizZz110 ChrizZz110 left a comment

LGTM

@ChrizZz110 ChrizZz110 merged commit 7138c74 into dbs-leipzig:develop Jun 25, 2019
1 check passed
p-f added a commit to p-f/gradoop that referenced this issue Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants