Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1190] Fix remaining Javadoc errors #1340

Merged
merged 23 commits into from Sep 16, 2019

Conversation

@timo95
Copy link
Contributor

commented Aug 1, 2019

  • Fix Javadoc errors (and improve style)
  • Activate some Javadoc checkstyle checks (not the same checks as maven-javadoc-plugin's doclint=all)

Fixes #1190

Copy link
Collaborator

left a comment

In general good work!
Many comments use some useless pseudocode, I think that should be replaced with an actual description. If that would require too many changes, we might want to have a second look at that issue in a separate PR.

timo95 and others added 12 commits Aug 8, 2019
@ChrizZz110

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

@timo95 There are some unresolved comments of @p-f . Please address them - then we can merge this PR.

galpha and others added 6 commits Sep 16, 2019
…/randomjump/functions/VCIComputeFunction.java

Co-Authored-By: Philip Fritzsche <p-f@users.noreply.github.com>
…/connectedcomponents/functions/CreateLongTargetIds.java

Co-Authored-By: Philip Fritzsche <p-f@users.noreply.github.com>
…tions/DictionaryEntry.java

Co-Authored-By: Philip Fritzsche <p-f@users.noreply.github.com>
…o 1190-remainingjavadoc
@timo95

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

Done

@galpha
galpha approved these changes Sep 16, 2019
Copy link
Contributor

left a comment

LGTM

@galpha galpha merged commit 497423e into dbs-leipzig:develop Sep 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@timo95 timo95 deleted the timo95:1190-remainingjavadoc branch Sep 16, 2019
galpha added a commit that referenced this pull request Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.