Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1314] Fix compare to for NULL_VALUE #1343

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@timo95
Copy link
Contributor

commented Aug 6, 2019

Still no comparison between most types.

Partly fixes #1314

@p-f

p-f approved these changes Aug 6, 2019

Copy link
Collaborator

left a comment

Looks good (for now).

I think you should add a comment to PropertyValue::compareTo stating that NULL_VALUE is considered less than all other properties.
There should also be a comment that this method violates the requirements of Comparable::compareTo by only supporting two PropertyValues with the same type.

@p-f

p-f approved these changes Aug 6, 2019

Copy link
Collaborator

left a comment

Looks good

@ChrizZz110
Copy link
Contributor

left a comment

Looks good.

@ChrizZz110 ChrizZz110 self-assigned this Aug 7, 2019

@ChrizZz110 ChrizZz110 merged commit 974dfd1 into dbs-leipzig:develop Aug 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timo95 timo95 deleted the timo95:1314-comparable branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.