Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1345] Generalize some functions to support other graph models #1346

Merged

Conversation

@ChrizZz110
Copy link
Contributor

commented Aug 8, 2019

Added changes from p-f to prepare gradoop-flink with generalizations for the new gradoop-temporal module.
fixes #1345
Picked from commit authored by @p-f

[#1345] Added changes from p-f to prepare gradoop-flink with generali…
…zations for the new gradoop-temporal module
@timo95

timo95 approved these changes Aug 8, 2019

Copy link
Contributor

left a comment

LGTM

@p-f

p-f approved these changes Aug 8, 2019

Copy link
Collaborator

left a comment

LGTM, but the PR title is too long and not very descriptive. Please change that or make sure that the actual commit message is more descriptive. Maybe something like "Generalize some functions in preparation of gradoop-temporal" or "Generalize some functions to support other graph models."

@ChrizZz110 ChrizZz110 changed the title [#1345] Added changes from p-f to prepare gradoop-flink with generali… [#1345] Generalize some functions to support other graph models Aug 8, 2019

ChrizZz110 added some commits Aug 8, 2019

@galpha

galpha approved these changes Aug 9, 2019

Copy link
Contributor

left a comment

LGTM

@ChrizZz110 ChrizZz110 merged commit 183e31c into dbs-leipzig:develop Aug 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.