Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1471] Added toLocalDateTime function to class TimeFormatConversion #1476

Merged
merged 2 commits into from Feb 18, 2020

Conversation

@ChrizZz110
Copy link
Contributor

ChrizZz110 commented Feb 10, 2020

A new function is added to convert a timestamp represented as milliseconds from epoch to a LocalDateTime object.

Description

The function consumes a long timestamp and converts it to a LocalDateTime object.

Related Issue

Motivation and Context

A helper function to easily convert timestamps e.g. for using the snapshot operator etc.

How Has This Been Tested?

Test function added.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (if necessary).
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I ran a spell checker.
@ChrizZz110 ChrizZz110 requested review from galpha and p-f Feb 10, 2020
Copy link
Collaborator

p-f left a comment

Just a minor mistake in a comment and another comment (though that is just personal preference)

@galpha
galpha approved these changes Feb 18, 2020
Copy link
Contributor

galpha left a comment

LGTM

@galpha galpha merged commit fc4cc87 into dbs-leipzig:develop Feb 18, 2020
2 checks passed
2 checks passed
build (ubuntu-latest)
Details
build (macos-latest)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.