New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#703] Add basic graph construction via pattern #715

Merged
merged 2 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@s1ck
Member

s1ck commented Dec 21, 2017

s1ck added some commits Nov 21, 2017

[#703] Add basic graph construction via pattern
[#703] Add basic graph construction via pattern

filter embeddings by return pattern variables

debug outputs

implement add embedding functions based on a return pattern

bugfix(embedding): add got accidentally called twice in map function

remove debug outputs and enable outer right join in post processing

implement label mapping for epgm elements that were created for the return pattern

code cleanup

clean code and write documentation

refactor(CypherPatternMatching): label mapping contains newly created edges + vertices only

fix(tests): avoid nullpointer exception by initializing empty map

reformat code

add missing documentation
[#703] Refactor graph construction code and update docs
* simplified code in CypherPatternMatching
* moved helper parts to QueryHandler

@s1ck s1ck merged commit 5d06a75 into master Dec 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@p-f

This comment has been minimized.

Show comment
Hide comment
@p-f

p-f Jan 4, 2018

Collaborator

There is an

import sun.reflect.generics.reflectiveObjects.NotImplementedException;

in LogicalGraph that I think should be removed (Internal API)

Collaborator

p-f commented Jan 4, 2018

There is an

import sun.reflect.generics.reflectiveObjects.NotImplementedException;

in LogicalGraph that I think should be removed (Internal API)

@s1ck

This comment has been minimized.

Show comment
Hide comment
@s1ck

s1ck Jan 6, 2018

Member

Good point. I wonder why checkstyle doesn't catch those anymore. I'll have a look

Member

s1ck commented Jan 6, 2018

Good point. I wonder why checkstyle doesn't catch those anymore. I'll have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment