Added failing tests for external, fix for tests
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If config follows has_many to dump a set, the set’s config is not used, so attrs such as `external` are not honoured. Even using `rules` does not solve the problem. Using unsorted `sets` array to specify dump order solves the problem. Signed-off-by: Charlie Garrison <cngarrison@gmail.com>
getting DateTime formatter from schema storage. Error can occur earlier in code, unrelated to datetime formatter, and cause formatter to not be set. Don’t bail due to ancient errors. Signed-off-by: Charlie Garrison <cngarrison@gmail.com>
|
Commit 8789030 wasn't supposed to be part of this PR; apologies for my lack of GitHub knowledge. I'm not sure how to separate it now. |
|
just saw this, I'll take a look this weekend. Thanks @cngarrison |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 27, 2017
1.001039 2017-09-25 14:15:55+00:00 UTC - remove trailing comma in tests that was breaking on most JSON parsers. 1.001038 2017-09-20 21:13:13+00:00 UTC - stop sorting source names before dumping, this allows for some hackery when you need certain sources to dump first (see dbsrgits/DBIx-Class-Fixtures#12 for details) (cngarrison++) - doc patch for exclude attr (simbabque++) 1.001037 2017-09-20 20:42:03+00:00 UTC - ignore virtual columns in dump_object (mmims++)
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Oct 22, 2017
1.001039 2017-09-25 14:15:55+00:00 UTC - remove trailing comma in tests that was breaking on most JSON parsers. 1.001038 2017-09-20 21:13:13+00:00 UTC - stop sorting source names before dumping, this allows for some hackery when you need certain sources to dump first (see dbsrgits/DBIx-Class-Fixtures#12 for details) (cngarrison++) - doc patch for exclude attr (simbabque++) 1.001037 2017-09-20 20:42:03+00:00 UTC - ignore virtual columns in dump_object (mmims++)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If config uses has_many to dump a set, the set’s config is not used, so attrs such as
externalare not honoured. Even usingrulesdoes not solve the problem. Using unsortedsetsarray to specify dump order solves the problem.Using extra.json from this commit as an example. The 'Album' set is configured to fetch all has_many photos. When sets are sorted as part of
dump, then the 'Album' set is dumped before the 'Photo' set, and theexternalattribute is not included.Putting 'Photo' first in the
setsarray should fix that dependancy, but doesn't if sets are sorted by class name. This patch removes the sorting of sets, and dumps them in the order defined in the config.The revised test files in this commit fail without the change to Fixtures.pm.
Whether the fix of 'not sorting' is correct solution is debatable. I believe that array order in config should be honoured, and not sorted by class name.