Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the excludes option for dump #13

Closed
wants to merge 1 commit into from

Conversation

simbabque
Copy link
Contributor

It would probably make sense to make it smart enough to ignore views automatically because those error when they are populated.

@samuelckaufman
Copy link
Contributor

merged, fixed a small typo in the pr which is displaying as a github conflict here.

@samuelkaufman
Copy link

samuelkaufman commented Sep 21, 2017

@simbabque it's live now. Thanks for the patch and apologies for not seeing this for so long.

@simbabque
Copy link
Contributor Author

I am not sure how you merged it without the PR marking as merged, but it's in. Thanks! :)

@simbabque simbabque closed this Sep 30, 2017
@samuelkaufman
Copy link

@simbabque has to do with the modification I made to your pr I guess? 627108d

Not really sure either.

@simbabque
Copy link
Contributor Author

It also says here that there are unmerged commits in my branch. How strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants