Exclude virtual columns #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixtures dumps virtual columns which causes populate to fail because the column doesn't exist in the table. This failing test demonstrates the problem.
Don't dump virtual columns since they don't exist in the table and populate will choke.
|
@semifor hey sorry just saw this, I'll check it out tomorrow morning, thanks for the pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dump_objectdumps the hash returned byget_columns. If the result source includes virtual columns defined withresultset_attributes, they get dumped as well. Then populating from fixtures fails because the virtual columns don't exist in the table.This change dumps only columns defined in
columns_info, effectively excluding the virtual columns.See t/lib/DBICTest/Schema3.pm for an example of a virtual column.
I'm not sure this in the best (or correct) way to exclude virtual columns, or even if defining virtual columns this way is correct. But this fixes an issue I encountered in an existing database and passes all other tests as well.
Two commits. The first is a failing test. The second is the fix.