New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Challenge #2

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@basbloemsaat

basbloemsaat commented Mar 1, 2015

Not very in depth, mostly housekeeping:

  • travis-ci working
  • Makefile was a generated file, no need to keep it in git
  • added a pg.sql to the tests so testing on travis with postgress passed

passes: https://travis-ci.org/basbloemsaat/DBIx-Class-Fixtures/builds/52664115

@ediblenergy

This comment has been minimized.

Contributor

ediblenergy commented Mar 9, 2015

Hey sorry I haven't responded yet, been very busy at work, but it looks good at a glance. I'll try to take a closer look and merge this week.
What this project really needs is an upstream fix in IO::All so it'll work properly in Windows, which is also a super simple patch. :)
see: ingydotnet/io-all-pm#74

@basbloemsaat

This comment has been minimized.

basbloemsaat commented Mar 9, 2015

Great.

I'll look into IO::All integration, IO::All is a distribution I actually
use regularly :).

Regards,
Bas

On Mon, Mar 9, 2015 at 3:01 PM, Samuel Kaufman notifications@github.com
wrote:

Hey sorry I haven't responded yet, been very busy at work, but it looks
good at a glance. I'll try to take a closer look and merge this week.
What this project really needs is an upstream fix in IO::All so it'll work
properly in Windows, which is also a super simple patch. :)
see: ingydotnet/io-all-pm#74
ingydotnet/io-all-pm#74


Reply to this email directly or view it on GitHub
#2 (comment)
.

@jjn1056

This comment has been minimized.

Contributor

jjn1056 commented Apr 21, 2015

hey just getting back to this and a few things:

+use IO::All do we really need that?

Also, any chance we can use sqlite instead of pg on travis for testing? I don't want to have to support both for testing if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment