use quote_identifiers for problematic column names #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1402,7 +1402,13 @@ sub populate { | |||
| $self->msg("- updating sequence $sequence"); | |||
| $rs->result_source->storage->dbh_do(sub { | |||
| my ($storage, $dbh, @cols) = @_; | |||
| $self->msg(my $sql = "SELECT setval('${sequence}', (SELECT max($column) FROM ${table}));"); | |||
| $self->msg( | |||
| my $sql = "SELECT setval('${sequence}', (SELECT max(" | |||
There was a problem hiding this comment.
The sequence name needs to be quoted (or even better, passed in via a placeholder) too.
|
Thanks that's a good point, $sequence is now pulled in via bind_param |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a proposed fix for https://rt.cpan.org/Public/Bug/Display.html?id=108017, $dbh->quote_identifiers() should take care of 'bad' column and table names. Unfortunately I don't have a Postgres-Database available so I created just a general testcase at https://gist.github.com/hatorikibble/6b3d937cd447f617f9a0