New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use quote_identifiers for problematic column names #8

Merged
merged 2 commits into from Dec 8, 2015

Conversation

Projects
None yet
4 participants
@hatorikibble
Contributor

hatorikibble commented Nov 30, 2015

this is a proposed fix for https://rt.cpan.org/Public/Bug/Display.html?id=108017, $dbh->quote_identifiers() should take care of 'bad' column and table names. Unfortunately I don't have a Postgres-Database available so I created just a general testcase at https://gist.github.com/hatorikibble/6b3d937cd447f617f9a0

@hatorikibble

This comment has been minimized.

Show comment
Hide comment
@hatorikibble

hatorikibble Dec 1, 2015

Contributor

Thanks that's a good point, $sequence is now pulled in via bind_param

Contributor

hatorikibble commented Dec 1, 2015

Thanks that's a good point, $sequence is now pulled in via bind_param

@dbsrgits-sync dbsrgits-sync merged commit b788f24 into dbsrgits:master Dec 8, 2015

@ediblenergy

This comment has been minimized.

Show comment
Hide comment
@ediblenergy

ediblenergy Dec 8, 2015

Contributor

merged, thanks!

Contributor

ediblenergy commented Dec 8, 2015

merged, thanks!

@hatorikibble hatorikibble deleted the hatorikibble:bugreport_108017 branch Jan 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment