From 04fd454731586d51e755643c7ec02ad0b5ced960 Mon Sep 17 00:00:00 2001 From: Francisco Obispo Date: Wed, 9 Aug 2017 16:41:08 -0700 Subject: [PATCH 1/2] added an option to omit the use of view_definitions inside the generated schema classes for server views --- lib/DBIx/Class/Schema/Loader/Base.pm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/DBIx/Class/Schema/Loader/Base.pm b/lib/DBIx/Class/Schema/Loader/Base.pm index 9103fafcf..e9cd0e39d 100644 --- a/lib/DBIx/Class/Schema/Loader/Base.pm +++ b/lib/DBIx/Class/Schema/Loader/Base.pm @@ -66,6 +66,7 @@ __PACKAGE__->mk_group_ro_accessors('simple', qw/ generated_classes omit_version omit_timestamp + omit_view_definitions relationship_attrs @@ -904,6 +905,10 @@ Omit the package version from the signature comment. Omit the creation timestamp from the signature comment. +=head2 omit_view_definitions + +Omit the creation of view definitions + =head2 custom_column_info Hook for adding extra attributes to the @@ -2626,8 +2631,9 @@ sub _setup_src_meta { $self->_dbic_stmt($table_class, 'table', $table->dbic_name); # Must come after ->table - if ($is_view and my $view_def = $self->_view_definition($table)) { - $self->_dbic_stmt($table_class, 'result_source_instance->view_definition', $view_def); + if ( $is_view and my $view_def = $self->_view_definition( $table ) and not $self->omit_view_definitions ){ + $self->_dbic_stmt( $table_class, + 'result_source_instance->view_definition', $view_def ); } my $cols = $self->_table_columns($table); From 946f5bfb6e5b77ecb5e8d5b2b33e3967adde58e3 Mon Sep 17 00:00:00 2001 From: Francisco Obispo Date: Wed, 9 Aug 2017 16:55:34 -0700 Subject: [PATCH 2/2] use long-line style --- lib/DBIx/Class/Schema/Loader/Base.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/DBIx/Class/Schema/Loader/Base.pm b/lib/DBIx/Class/Schema/Loader/Base.pm index e9cd0e39d..c1a345446 100644 --- a/lib/DBIx/Class/Schema/Loader/Base.pm +++ b/lib/DBIx/Class/Schema/Loader/Base.pm @@ -2632,8 +2632,7 @@ sub _setup_src_meta { # Must come after ->table if ( $is_view and my $view_def = $self->_view_definition( $table ) and not $self->omit_view_definitions ){ - $self->_dbic_stmt( $table_class, - 'result_source_instance->view_definition', $view_def ); + $self->_dbic_stmt( $table_class,'result_source_instance->view_definition', $view_def ); } my $cols = $self->_table_columns($table);