update the dsn in the documented example #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double quotes appear to have been left in by accident and can lead to connection errors for those not paying close attention.
|
Are you actually seeing errors? DBD::Pg allows quoted database names just fine (required if there's e.g. a space in the database name). Other DBDs may vary, but then you have to change the DSN anyway. |
|
my apologies. i was using mysql and just assumed it was an oversight. will close this now. FYI: you seem to have a separate issue with your travis-ci build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double quotes appear to have been left in by accident and can lead to connection errors for those not paying close attention.