do not require MooseX::MarkAsMethods with only_autoclean=1 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When use_moose=1 and only_autoclean=1, we do not require MooseX::MarkAsMethods, but require a more recent version of Moose. Check for whichever set of prereqs is appropriate. Technically, we don't need MXMAM at all if Moose is at 2.1400, but the generated code will still (for now) use the MXMAM constructs if only_autoclean is not set. This gives the user more flexibility if their Moose installation isn't at a new enough version on all systems.
|
Looks like travis succeeded, except for some transient network hiccups. |
|
Thanks, merged in 6d0f962 |
|
many thanks! |
yanick
added a commit
to yanick/RapidApp
that referenced
this pull request
Feb 2, 2024
fixes vanstyn#80 According to dbsrgits/dbix-class-schema-loader#21, the fix that removes the need for MooseX::MAM is merged in as of dbix-class-chema-loader v0.07051.
yanick
added a commit
to yanick/RapidApp
that referenced
this pull request
Feb 2, 2024
fixes vanstyn#80 According to dbsrgits/dbix-class-schema-loader#21, the fix that removes the need for MooseX::MAM is merged in as of dbix-class-chema-loader v0.07051.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use_moose=1 and only_autoclean=1, we do not require
MooseX::MarkAsMethods, but require a more recent version of Moose. Check
for whichever set of prereqs is appropriate.
Technically, we don't need MXMAM at all if Moose is at 2.1400, but the
generated code will still (for now) use the MXMAM constructs if
only_autoclean is not set. This gives the user more flexibility if
their Moose installation isn't at a new enough version on all systems.