Skip to content
Browse files

Back out frivolous loading of threads.pm

Not only was this an unsuccesful attempt to mask out a bug introduced
in Moo's inlining of Devel::GlobalDestruction (since fixed), but it
broke a test under older win32 perls.
Revert 8bab206, bump Moo dep
  • Loading branch information...
1 parent 691583d commit dfd722efa2fb42fce57a64e0bcc818a900e85a92 @ribasushi ribasushi committed Nov 18, 2012
Showing with 2 additions and 11 deletions.
  1. +1 −0 Changes
  2. +1 −4 Makefile.PL
  3. +0 −3 TODO_SHORTTERM
  4. +0 −4 t/storage/txn.t
View
1 Changes
@@ -3,6 +3,7 @@ Revision history for DBIx::Class
* Fixes
- More robust behavior under heavily threaded environments - make
sure we do not have refaddr reuse in the global storage registry
+ - Fix failing test on 5.8 under Win32 (RT#81114)
0.08204 2012-11-08
* New Features / Changes
View
5 Makefile.PL
@@ -42,9 +42,6 @@ my $runtime_requires = {
# FIXME - temporary, needs throwing out for something more efficient
'Data::Compare' => '1.22',
- # Moo does not yet depend on this higher version
- 'strictures' => '1.003001',
-
# DBI itself should be capable of installation and execution in pure-perl
# mode. However it has never been tested yet, so consider XS for the time
# being
@@ -64,7 +61,7 @@ my $runtime_requires = {
'Data::Page' => '2.00',
'Devel::GlobalDestruction' => '0',
'Hash::Merge' => '0.12',
- 'Moo' => '0.009100',
+ 'Moo' => '1.000006',
'MRO::Compat' => '0.09',
'Module::Find' => '0.06',
'namespace::clean' => '0.20',
View
3 TODO_SHORTTERM
@@ -1,6 +1,3 @@
-* 8bab2062 preloading threads.pm is absolute bullshit - remove and find out
-the real problem (might very well be a Moo bug). But seriously - preloading
-threads.pm in a BEGIN block?!?!?!
* 50e6c52e reenable the test and investigate. A blatant skip is fucking
bullshit
* a0361822 reenable the win32 test - if it no longer fails for anyone - how
View
4 t/storage/txn.t
@@ -1,10 +1,6 @@
use strict;
use warnings;
-BEGIN {
- require threads if $^O eq 'MSWin32'; # preload due to fork errors
-}
-
use Test::More;
use Test::Warn;
use Test::Exception;

0 comments on commit dfd722e

Please sign in to comment.
Something went wrong with that request. Please try again.