Permalink
Switch branches/tags
Commits on Oct 18, 2012
  1. release 0.08203

    frioux committed Oct 18, 2012
Commits on Oct 15, 2012
  1. release 0.08202_01

    frioux committed Oct 15, 2012
Commits on Oct 12, 2012
  1. Really fix the DBD::SQLite ping() issue

    Apparently DBD::SQLite is notoriously bad at synchronizing its internal
    transaction state with {AutoCommit}
    https://metacpan.org/source/ADAMK/DBD-SQLite-1.37/lib/DBD/SQLite.pm#L921
    There is a function http://www.sqlite.org/c3ref/get_autocommit.html
    but DBD::SQLite does not expose it (nor does it seem to properly use it)
    
    Furthermore the detection is rather broken as described in RT#80087.
    Bend over backwards to attempt to preserve as much sanity as possible.
    While at it issue a non-trappable warning so that folks fix the offending
    codepath (which arguably is still broken)
    
    It is possible to have a proper "connection", and have "ping" return
    false anyway (e.g. corrupted file). In such cases DBD::SQLite still
    keeps the actual file handle open. We don't really want this to happen,
    so force-close the handle via DBI itself (this solves a bunch of Win32
    test failures)
    ribasushi committed Oct 9, 2012
Commits on Oct 6, 2012
Commits on Oct 5, 2012
  1. release 0.08201

    frioux committed Oct 5, 2012
  2. Replace inadequate $dbh->ping SQLite implementation (RT#78420)

    When SQLite attempts to connect to a file that is not a database,
    it nevertheless maintains a true $dbh->{Active} and $dbh->ping.
    Replace with a schema listing SELECT, and fix test erroneously
    assuming it can portably do chmod 000
    ribasushi committed with frioux Aug 30, 2012
Commits on Sep 1, 2012
  1. Revert "Fix t/storage/reconnect.t when run as root"

    The test change just papered over the problem, a proper fix is pending
    on the for_current/riba/fix_sqlite_ping_RT78420 branch.
    
    This reverts commit 64819b0.
    ilmari committed Sep 1, 2012
  2. Fix t/storage/reconnect.t when run as root

    As root, the chmod 000 doesn't prevent SQLite form opening the fake db
    file, so we need to disconnect to make it reopen the restored real one.
    ilmari committed Sep 1, 2012
Commits on Aug 25, 2012
Commits on Aug 24, 2012
  1. release 0.08200

    frioux committed Aug 24, 2012
Commits on Aug 23, 2012
  1. release 0.08199

    frioux committed Aug 23, 2012
  2. Dev release changes

    castaway committed with frioux Aug 1, 2012
  3. Back out constructor/prefetch rewrite introduced mainly by 43245ad

    It was shipped against the authors advice, while containing multiple known
    bugs. After the expected bugreports went warnocked for over two weeks by the
    new DBIC release team, it seems that the only way to partially restore the
    release quality DBIC users have come to expect, is to currently throw this
    code away until better times.
    
    Should resolve RT#78456 and the issues reported in these threads:
    http://lists.scsys.co.uk/pipermail/dbix-class/2012-July/010681.html
    http://lists.scsys.co.uk/pipermail/dbix-class/2012-July/010682.html
    ribasushi committed with frioux Jul 24, 2012
Commits on Jul 17, 2012
  1. Fix Class::AccessorGroup to allow instances in get_component_class.

     Fixes result_class($obj) exploding instead of just using the object.
    gbjk committed Jul 17, 2012
Commits on Jul 11, 2012
  1. release v0.08198

    frioux committed Jul 11, 2012
Commits on Jul 10, 2012
  1. fix silent Oracle connection failures

    ::Storage::DBI::_server_info was eating connection exceptions by
    ignoring exceptions from $dbh->get_info, but this information is
    important for _rebless when e.g. determining which class to use based on
    the DB server version, so rethrow the exceptions when
    $self->{_in_determine_driver} is true.
    rkitover committed Jun 24, 2012
  2. better type check for mssql+ado binary null strip

    The data_type in the t/lib result class for the blob for the tests
    changed to 'blob', while the binary type null stripper only expected
    'binary' or 'image' data types, which is wrong for possibly
    cross-deployed schemas.
    
    Change _strip_trailing_binary_nulls in ::ADO::CursorUtils to use the
    newly added and more generic ::Storage::DBI::_is_binary_type instead of
    just checking for 'binary' or 'image'.
    rkitover committed Jun 24, 2012
  3. mark some tests in admin/10script.t on Win32 TODO

    The test_dbicadmin() tests are failing on Win32 due to some sort of
    quoting issue with the temp directory. I'm not sure how the temp
    directory is being used here, so it will have to wait for someone else,
    in the meanwhile I marked the tests TODO.
    
    Also changed the " backwhacking to use Win32::ShellQuote instead and
    added it to optdeps, unfortunately that didn't fix the problem, since
    the problem seems to be some sort of DBICTest::RunMode interaction with
    dbicadmin.
    rkitover committed Jun 24, 2012
  4. preload threads.pm in storage/txn.t for fork error

    SineSwiper reported this error in t/storage/txn.t on Strawberry Perl
    5.12 32bit:
    
    You must load the 'threads' module before Moo::_Utils at t/storage/txn.t
    line 130.
    
    Preload threads in a BEGIN block at the beginning of the .t file for
    Win32. This fixes the error.
    rkitover committed Jun 18, 2012
  5. skip 51threadnodb.t on Win32 on < 5.14

    SineSwiper reported a crash with a dialog from "make test" in
    t/51threadnodb.t on Strawberry Perl 5.12 32bit.
    
    The test passes on my ActivePerl 64bit 5.14.2 and there is a passing
    test report for 5.14 here:
    http://www.cpantesters.org/cpan/report/239d2ae4-87c3-1015-ad08-a09405085451
    
    Disable test on Win32 for perls below 5.14 unless the environment
    variable TEST_AUTHOR is set to be safe.
    rkitover committed Jun 18, 2012
  6. release 0.08197

    frioux committed Jul 10, 2012
  7. fix pod for unicode name

    frioux committed Jul 10, 2012
Commits on Jun 20, 2012
Commits on Jun 15, 2012
  1. fix broken syntax

    arcanez committed Jun 15, 2012
  2. Add authority for new moules

    ribasushi committed Jun 15, 2012