Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Oct 18, 2012
  1. @frioux

    release 0.08203

    frioux committed
Commits on Oct 15, 2012
  1. @frioux

    release 0.08202_01

    frioux committed
Commits on Oct 12, 2012
  1. @ribasushi

    Really fix the DBD::SQLite ping() issue

    ribasushi committed
    Apparently DBD::SQLite is notoriously bad at synchronizing its internal
    transaction state with {AutoCommit}
    There is a function
    but DBD::SQLite does not expose it (nor does it seem to properly use it)
    Furthermore the detection is rather broken as described in RT#80087.
    Bend over backwards to attempt to preserve as much sanity as possible.
    While at it issue a non-trappable warning so that folks fix the offending
    codepath (which arguably is still broken)
    It is possible to have a proper "connection", and have "ping" return
    false anyway (e.g. corrupted file). In such cases DBD::SQLite still
    keeps the actual file handle open. We don't really want this to happen,
    so force-close the handle via DBI itself (this solves a bunch of Win32
    test failures)
  2. @ribasushi
Commits on Oct 6, 2012
  1. @shadowcat-mst
Commits on Oct 5, 2012
  1. @frioux

    release 0.08201

    frioux committed
  2. @ribasushi @frioux
  3. @ribasushi @frioux

    Replace inadequate $dbh->ping SQLite implementation (RT#78420)

    ribasushi committed with frioux
    When SQLite attempts to connect to a file that is not a database,
    it nevertheless maintains a true $dbh->{Active} and $dbh->ping.
    Replace with a schema listing SELECT, and fix test erroneously
    assuming it can portably do chmod 000
Commits on Sep 1, 2012
  1. @ilmari
  2. @ilmari

    Revert "Fix t/storage/reconnect.t when run as root"

    ilmari committed
    The test change just papered over the problem, a proper fix is pending
    on the for_current/riba/fix_sqlite_ping_RT78420 branch.
    This reverts commit 64819b0.
  3. @ilmari

    Fix t/storage/reconnect.t when run as root

    ilmari committed
    As root, the chmod 000 doesn't prevent SQLite form opening the fake db
    file, so we need to disconnect to make it reopen the restored real one.
Commits on Aug 25, 2012
  1. @ilmari
Commits on Aug 24, 2012
  1. @ilmari
  2. @frioux

    release 0.08200

    frioux committed
  3. @frioux
  4. @frioux
Commits on Aug 23, 2012
  1. @frioux

    release 0.08199

    frioux committed
  2. @castaway @frioux

    Dev release changes

    castaway committed with frioux
  3. @ribasushi @frioux

    Back out constructor/prefetch rewrite introduced mainly by 43245ad

    ribasushi committed with frioux
    It was shipped against the authors advice, while containing multiple known
    bugs. After the expected bugreports went warnocked for over two weeks by the
    new DBIC release team, it seems that the only way to partially restore the
    release quality DBIC users have come to expect, is to currently throw this
    code away until better times.
    Should resolve RT#78456 and the issues reported in these threads:
  4. @edenc @frioux
  5. @rkitover @frioux
  6. @castaway @frioux
Commits on Jul 17, 2012
  1. @gbjk

    Fix Class::AccessorGroup to allow instances in get_component_class.

    gbjk committed
     Fixes result_class($obj) exploding instead of just using the object.
Commits on Jul 11, 2012
  1. @frioux

    release v0.08198

    frioux committed
Commits on Jul 10, 2012
  1. @rkitover

    fix silent Oracle connection failures

    rkitover committed
    ::Storage::DBI::_server_info was eating connection exceptions by
    ignoring exceptions from $dbh->get_info, but this information is
    important for _rebless when e.g. determining which class to use based on
    the DB server version, so rethrow the exceptions when
    $self->{_in_determine_driver} is true.
  2. @rkitover

    better type check for mssql+ado binary null strip

    rkitover committed
    The data_type in the t/lib result class for the blob for the tests
    changed to 'blob', while the binary type null stripper only expected
    'binary' or 'image' data types, which is wrong for possibly
    cross-deployed schemas.
    Change _strip_trailing_binary_nulls in ::ADO::CursorUtils to use the
    newly added and more generic ::Storage::DBI::_is_binary_type instead of
    just checking for 'binary' or 'image'.
  3. @rkitover

    mark some tests in admin/10script.t on Win32 TODO

    rkitover committed
    The test_dbicadmin() tests are failing on Win32 due to some sort of
    quoting issue with the temp directory. I'm not sure how the temp
    directory is being used here, so it will have to wait for someone else,
    in the meanwhile I marked the tests TODO.
    Also changed the " backwhacking to use Win32::ShellQuote instead and
    added it to optdeps, unfortunately that didn't fix the problem, since
    the problem seems to be some sort of DBICTest::RunMode interaction with
  4. @rkitover

    preload in storage/txn.t for fork error

    rkitover committed
    SineSwiper reported this error in t/storage/txn.t on Strawberry Perl
    5.12 32bit:
    You must load the 'threads' module before Moo::_Utils at t/storage/txn.t
    line 130.
    Preload threads in a BEGIN block at the beginning of the .t file for
    Win32. This fixes the error.
  5. @rkitover

    skip 51threadnodb.t on Win32 on < 5.14

    rkitover committed
    SineSwiper reported a crash with a dialog from "make test" in
    t/51threadnodb.t on Strawberry Perl 5.12 32bit.
    The test passes on my ActivePerl 64bit 5.14.2 and there is a passing
    test report for 5.14 here:
    Disable test on Win32 for perls below 5.14 unless the environment
    variable TEST_AUTHOR is set to be safe.
  6. @frioux

    release 0.08197

    frioux committed
  7. @frioux
  8. @frioux

    fix pod for unicode name

    frioux committed
Commits on Jun 20, 2012
  1. @SineSwiper
Commits on Jun 15, 2012
  1. @arcanez

    fix broken syntax

    arcanez committed
  2. @ribasushi

    Add authority for new moules

    ribasushi committed
Something went wrong with that request. Please try again.