Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Nov 8, 2012
  1. @Getty

    Release 0.08204

    Getty committed
  2. @ribasushi
Commits on Nov 5, 2012
  1. @ribasushi
  2. @ribasushi
  3. @ribasushi
  4. @ribasushi
  5. @ribasushi
Commits on Nov 4, 2012
  1. @ribasushi
  2. @ribasushi
Commits on Nov 3, 2012
  1. @felliott @ribasushi
  2. @ribasushi

    Fix API mismatch between new_related() and new_result() (RT#78336)

    ribasushi committed
    Almost 7 years ago a refactor in fea3d04 fed an (undocumented) $attrs
    parameter from new_related() to new_result(), while new_result() never
    expected (and ignored) said parameter. Since this is an undocumented
    feature, which nobody complained about for all this time - document
    extensively and kill it with fire.
  3. @ribasushi
  4. @ribasushi
  5. @ribasushi
  6. @alexrj @ribasushi
  7. @ribasushi

    Fix unique constraint violations in blanket movement (RT#7…

    ribasushi committed
    This essentially reverts 5e6fde3 which was applied without much thinking.
    Added a test to ensure this doesn't re-break again.
  8. @ribasushi

    Properly signify internal cursor methods, trash their accessors as well

    ribasushi committed
    (the accessors were not used throughout anyway)
  9. @rkitover @ribasushi

    fix Cursor SYNOPSIS

    rkitover committed with ribasushi
  10. @ribasushi
  11. @mattp- @ribasushi

    Let SQLMaker rs_attr 'for' support string literals

    mattp- committed with ribasushi
    SQLMaker previously only allowed hardcoded values with the 'for' attr,
    overriding in storage specific subclasses. Rather than attempt to provide an
    exhaustive list of possible options, the base class can now take \$scalaras
    an override that is embedded directly in the returned $sql
  12. @ribasushi
  13. @ribasushi

    Fix invalid pod example syntax

    Felix Antonius Wilhelm Ostmann committed with ribasushi
Commits on Oct 20, 2012
  1. @ribasushi

    release 0.08203_01

    ribasushi committed
  2. @ribasushi
Commits on Oct 18, 2012
  1. @frioux

    release 0.08203

    frioux committed
Commits on Oct 15, 2012
  1. @frioux

    release 0.08202_01

    frioux committed
Commits on Oct 12, 2012
  1. @ribasushi

    Really fix the DBD::SQLite ping() issue

    ribasushi committed
    Apparently DBD::SQLite is notoriously bad at synchronizing its internal
    transaction state with {AutoCommit}
    There is a function
    but DBD::SQLite does not expose it (nor does it seem to properly use it)
    Furthermore the detection is rather broken as described in RT#80087.
    Bend over backwards to attempt to preserve as much sanity as possible.
    While at it issue a non-trappable warning so that folks fix the offending
    codepath (which arguably is still broken)
    It is possible to have a proper "connection", and have "ping" return
    false anyway (e.g. corrupted file). In such cases DBD::SQLite still
    keeps the actual file handle open. We don't really want this to happen,
    so force-close the handle via DBI itself (this solves a bunch of Win32
    test failures)
  2. @ribasushi
Commits on Oct 6, 2012
  1. @shadowcat-mst
Commits on Oct 5, 2012
  1. @frioux

    release 0.08201

    frioux committed
  2. @ribasushi @frioux
  3. @ribasushi @frioux

    Replace inadequate $dbh->ping SQLite implementation (RT#78420)

    ribasushi committed with frioux
    When SQLite attempts to connect to a file that is not a database,
    it nevertheless maintains a true $dbh->{Active} and $dbh->ping.
    Replace with a schema listing SELECT, and fix test erroneously
    assuming it can portably do chmod 000
Commits on Sep 1, 2012
  1. @ilmari
  2. @ilmari

    Revert "Fix t/storage/reconnect.t when run as root"

    ilmari committed
    The test change just papered over the problem, a proper fix is pending
    on the for_current/riba/fix_sqlite_ping_RT78420 branch.
    This reverts commit 64819b0.
  3. @ilmari

    Fix t/storage/reconnect.t when run as root

    ilmari committed
    As root, the chmod 000 doesn't prevent SQLite form opening the fake db
    file, so we need to disconnect to make it reopen the restored real one.
Something went wrong with that request. Please try again.