Permalink
Commits on Feb 20, 2013
  1. Release v0.08208

    ribasushi committed Feb 20, 2013
  2. Even more distbuilding checks

    Frew's environment (and *only* his environment) keeps producing weirdly
    broken dists. Add an extra check for this until we figure out how exactly
    his environment is broken.
    
    Extra check tested on cygwin and strawberry for good measure.
    ribasushi committed Feb 20, 2013
Commits on Feb 18, 2013
  1. Prevent SQL::Translator::Producer::YAML from seeing our potential $dbh

    The failure mode here is extremely convoluted, full of unimaginable fail
    and makes baby jesus cry :(
    
    The long story: there are two ways to supply a $schema to the SQLT producer:
    via an argument to translate() (sane) or at the time of translator instance
    creation (less sane). In the second case this becomes a problem because some
    serializing producers (e.g. SQLT::Producer::YAML) take the *entire*
    SQLT instance and dump it to YAML. This includes the arguments which include
    our schema with its storage and potentially its $dbh. This causes the
    weird warnings described in e.g. RT#75394, because YAML creates a dead
    DBI object upon de-serialization of said arguments. What's even more sad is
    that while the YAML Producer dumps the entire SQLT instance, the YAML Parser
    simply takes the ->{schema} part of this structure and throws everything
    else away.
    
    Of course we can not just fix the ::Producer - folks may very well be relying
    on the structure it spits out (nobody knows if the *only* consumer of the
    Producer::YAML output is in fact Parser::YAML). Really the only thing we can
    know (well not know, but reasonably assume) is that there is no way that any
    user relies on the accessing the storage passed in with a schema instance to
    be parsed.
    
    So what we do is the least invasive thing of all - at translate() time we
    check the state of the passed in $schema and if it does have a storage
    instance we simply detach it (by cloning the $schema instance) and as a
    result everything remains happy.
    ribasushi committed Feb 16, 2013
  2. Deprecate the insane forest of SQLT::Parser::DBIC arguments

    It seems like things have been just piled up with no plan nor reason. Bring in
    the broom - converge on an argument name that actuall makes sense - dbic_schema
    ribasushi committed Feb 16, 2013
Commits on Feb 16, 2013
  1. Readjust the parallel no-test dependency install order

    Better utilize the massive amount of CPUs we have available
    ribasushi committed Feb 16, 2013
  2. It appears that travis drastically increased the amount of available …

    …CPUs
    
    Well, this is awesome - we just happen to be equipped to take advantage
    of this ;)
    
    Remove the branch-name limitations - now a smoke takes fraction of the time
    it used to, no point to limit what we smoke anymore.
    
    At the same time reduce the amount of threads building the perls - older
    binaries do not build very well on -j32. This is a temporary thing - the
    perl-building will soon be exported away anyway.
    ribasushi committed Feb 16, 2013
Commits on Feb 15, 2013
Commits on Feb 14, 2013
Commits on Feb 13, 2013
  1. Stop shipping world writeable files in our tarball

    The chain of failures would go as follows: when we prepare the tarball
    we briefly copy all generated POD to our root dir so that the
    manifest/distdir_copy process can pick it up. Then before the distdir is
    ready we run a cleanup using ExtUtils::Install::uninstall. However
    everything in the ditdir is hardlinked to our root dir, including the
    files we "uninstall". EU::I::uninstall has a weird dance deep in its
    source[1] where it explicitly does chmod(0666) on the file it is about
    to delete (why?!). Thus we end up with world-writables in our distdir,
    since the hardlinked inode still retains the result of that last chmod.
    
    Switch to a manual cleanup, and leave EU::I alone.
    
    [1] https://metacpan.org/source/YVES/ExtUtils-Install-1.54/lib/ExtUtils/Install.pm#L274
    ribasushi committed Feb 13, 2013
  2. Fix duplicated columns for count()

    When a same aggregate function was used more than once in a 'having'
    clause, count() added that function more than once to 'select'.
    andrewalker committed with ribasushi Feb 13, 2013
Commits on Feb 11, 2013
  1. release v0.08206

    abraxxa committed Feb 11, 2013
Commits on Feb 7, 2013
  1. Try to config Fibrebird twice - it does seem to help >.<

    Read changeset under -w
    ribasushi committed Feb 7, 2013
Commits on Feb 1, 2013
  1. Revert parts of 6864429 which utterly broke dbh_do() retries

    Was never noticed because of undertesting, now should behave correctly
    ribasushi committed Feb 1, 2013
  2. Clarify travis timings

    ribasushi committed Feb 1, 2013
Commits on Jan 29, 2013
Commits on Jan 25, 2013
  1. More .mailmap fixes

    ribasushi committed Dec 20, 2012
  2. General cleanup of error messages - quote identifiers/names where sen…

    …sible
    
    No functional changes
    ribasushi committed Sep 1, 2011
  3. Revert 344f761 - this was a stupid idea

    Way too many failures, maked CPANTesters output unusable.
    Extracted and submitted as DBI RT#82942 instead
    ribasushi committed Jan 25, 2013
Commits on Jan 23, 2013
  1. ::Storage::BlockRunner now has minimum POD, tell CPAN to noindex

    It is not ready for prime time yet
    ribasushi committed Jan 23, 2013
  2. release v0.08205

    frioux committed Jan 23, 2013
Commits on Jan 22, 2013
  1. Ensure xt/whitespace.t executes standalone

    This way it will not pick up anything temporary a test may have left
    around, and won't complain about the whitespace contents.
    ribasushi committed Jan 22, 2013
  2. Clarifying that the "around" method modifier can come from Moose

    Also adding a trailing semicolon to the "around" example. This way, it
    better agrees with the information in Manual::FAQ.
    jmacdotorg committed with ribasushi Jan 22, 2013