mst mentioned that this doc mention of "result_class" is incorrect (and conflicts with the one in ResultSet.pm) #21

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@castaway
Contributor
castaway commented Apr 3, 2013

No description provided.

@dbsrgits-sync

On Wed, Apr 03, 2013 at 09:45:10AM -0700, castaway wrote:

  • Corrent hashrefinflator's docs re result_class use

In isolation the patch is correct, however if you look at the big picture:

  • The mention of the classdata fiddling must go - there is no valid use
    case for it and there haven't been for years
  • Instead of attempting to (poorly) explain the difference between a
    result_class accessor and a result_class attribute, perhaps the doc
    should simply link to the correct explanation ... which however does not
    exist anywhere. The current behavior is codified here [1] between lines
    20 and 55.

CAN HAZ MOAR DOC PLZ? ;)

[1] https://metacpan.org/source/ABRAXXA/DBIx-Class-0.08209/t/inflate/hri.t#L20

@preaction preaction added a commit to preaction/dbix-class that referenced this pull request Nov 19, 2016
@preaction preaction clarify result_class attribute of ResultSet objects
This expands on #21 to add similar documentation to the ResultSet class
itself, explaining how the accessor method differs in behavior from the
attributes passed in to the search() method.
3ff9e12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment