Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

people/f0rk/format sql #1

Closed
wants to merge 5 commits into from
Closed

Conversation

f0rk
Copy link
Contributor

@f0rk f0rk commented Jun 29, 2011

This branch modifies the way queries are formatted by unparse so that when using format-sql the output is (IMHO) more readable. This also modifies the behavior of format-sql to slurp all of its input, instead of on a line by line basis.

@ribasushi
Copy link
Contributor

On f0rk@0114527 - this makes no sense. FROM and subsequent JOINs describe a single source. They have to all be indented at the same level.

@f0rk
Copy link
Contributor Author

f0rk commented Jul 13, 2011

"Have" is a strong word as I don't believe a parser will care about the indentation, it's only there for readability. At any rate, frew asked me to add command-line switches to control this behavior so that will go back to the way it originally was. You can close this pull request if you'd like and I'll open a new one when I'm done with the requested changes.

@frioux
Copy link
Member

frioux commented Jul 13, 2011

Well, just to be clear, I meant make it configurable, note that the formatter isn't just used from the little script included with the dist, but that would become obvious when you started to implement it anyway

@ribasushi
Copy link
Contributor

I am closing this PR given the above answers, please feel free to continue the discussion here or on the mailing list.

@ribasushi ribasushi closed this Dec 26, 2013
@frioux
Copy link
Member

frioux commented Dec 27, 2013

Yeah, a sep dist would be fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants