Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reusable _update_set_values method, consistent with _insert_values #12

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Conversation

kraih
Copy link
Contributor

@kraih kraih commented Jan 26, 2018

As discussed on IRC, this patch adds a reusable _update_set_values method that can be reused by SQL::Abstract extensions, just like _insert_values. The specific use case i have in mind for this will be PostgreSQL upserts, which rely on INSERT ... ON CONFLICT DO UPDATE SET ... queries.

@codecov-io
Copy link

codecov-io commented Jan 26, 2018

Codecov Report

Merging #12 into master will increase coverage by 0.07%.
The diff coverage is 93.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12      +/-   ##
=======================================
+ Coverage   82.93%   83%   +0.07%     
=======================================
  Files           3     3              
  Lines         920   924       +4     
  Branches      189   189              
=======================================
+ Hits          763   767       +4     
  Misses        107   107              
  Partials       50    50
Impacted Files Coverage Δ
lib/SQL/Abstract.pm 82.2% <93.33%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765bd89...e211f78. Read the comment docs.

@ilmari ilmari merged commit 9ade906 into dbsrgits:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants