Add overloadable _select_field_values method #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 83% 83.06% +0.05%
==========================================
Files 3 3
Lines 924 927 +3
Branches 189 189
==========================================
+ Hits 767 770 +3
Misses 107 107
Partials 50 50
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 14
💛 - Coveralls |
|
Not sure about the name, maybe |
ilmari
requested changes
Jan 28, 2018
lib/SQL/Abstract.pm
Outdated
| : $fields; | ||
| my $sql = join(' ', $self->_sqlcase('select'), $f, | ||
| my ($fields_sql, @fields_bind) = $self->_select_field_values($fields); | ||
| push @bind, @fields_bind; |
There was a problem hiding this comment.
Because $fields_sql comes before $where_sql, @fields_bind need to come before the bind values returned by ->where(). I'd suggest moving the whole fields part before the where part, to make this clearer.
…alues and _insert_values
|
Ok, fixed and squashed. |
|
Thanks, merged with minor tweaks as daa4ccd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is very similar to #12. It adds a new method
_select_field_valuesto be used as an extension hook, similar to_update_set_valuesand_insert_values.