Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace the literal string '0' with '' #14

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

fabzzap
Copy link
Contributor

@fabzzap fabzzap commented Apr 6, 2018

In Perl, the literal string '0' is false.

Because of this, if one uses the scalar ref "0", SQL::Abstract considers it a 'false' string and replaces it with an empty string. This patch avoids that, every string that at least one non-whitespache character is used.

@codecov-io
Copy link

codecov-io commented Apr 6, 2018

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files           3        3           
  Lines         927      927           
  Branches      189      189           
=======================================
  Hits          770      770           
  Misses        107      107           
  Partials       50       50
Impacted Files Coverage Δ
lib/SQL/Abstract.pm 82.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa4ccd...417dd15. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 6, 2018

Pull Request Test Coverage Report for Build 23

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 88.565%

Files with Coverage Reduction New Missed Lines %
lib/SQL/Abstract.pm 1 89.6%
Totals Coverage Status
Change from base Build 15: 0.0%
Covered Lines: 821
Relevant Lines: 927

💛 - Coveralls

@dbsrgits-sync dbsrgits-sync merged commit 417dd15 into dbsrgits:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants