Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpantesters fails #16

Closed
wants to merge 2 commits into from
Closed

Fix cpantesters fails #16

wants to merge 2 commits into from

Conversation

ribasushi
Copy link
Contributor

  • Do not use undeclared dep in test, use builtin instead
  • Add punctuation to run-on statement not recognized by 5.8

- Do not use undeclared dep in test, use builtin instead
- Add punctuation to run-on statement not recognized by 5.8
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (q@cf6817b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##             q      #16   +/-   ##
====================================
  Coverage     ?   74.78%           
====================================
  Files        ?        7           
  Lines        ?     1289           
  Branches     ?      362           
====================================
  Hits         ?      964           
  Misses       ?      241           
  Partials     ?       84
Impacted Files Coverage Δ
lib/SQL/Abstract/Plugin/ExtraClauses.pm 93.93% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6817b...8f8c731. Read the comment docs.

@shadowcat-mst
Copy link
Member

These are all good and I need to double-check and then merge them (bit drunk now).

Thanks!

@karenetheridge
Copy link

This is still not yet merged?

@ribasushi
Copy link
Contributor Author

obsolete dist

@ribasushi ribasushi closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants