Adjust passthrough example #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that further adjustments will have to be made for the DBIC version currently in 'master', but such adjustments are very likely going to be of comparable complexity to what was needed here. No warranties explicit or implicit either way.
|
Now that 0.082842 shipped, this PR is no longer relevant. Instead https://github.com/dbsrgits/sql-abstract/pull/17/files#diff-eb3465614a3d3abc2ae036e4ba07afcaR30-R45 needs to be packaged and shipped as a standalone dist* Closing. *It could be shipped as part of SQLA, but at present this would create a dependency resolution cycle: I am slowly working on ensuring SQLAC drops the SQLA dependncy entirely, but OSS time is extremely scarce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work out of the box without further changes with https://metacpan.org/release/RIBASUSHI/DBIx-Class-0.082841_01
@haarg note how I need to do set_mro() in the last hunk, this is something With::Role should preserve on its own.