Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl 5.8 compatibility #20

Closed
wants to merge 1 commit into from
Closed

perl 5.8 compatibility #20

wants to merge 1 commit into from

Conversation

DrHyde
Copy link

@DrHyde DrHyde commented Feb 24, 2021

On perl 5.8.9 there is currently a syntax error:

t/80extra_clauses.t ....... Useless use of unshift with no values at /Volumes/Vault/david/git-repos/sql-abstract/blib/lib/SQL/Abstract/Plugin/ExtraClauses.pm line 126.
syntax error at /Volumes/Vault/david/git-repos/sql-abstract/blib/lib/SQL/Abstract/Plugin/ExtraClauses.pm line 126, near "]{queries"
syntax error at /Volumes/Vault/david/git-repos/sql-abstract/blib/lib/SQL/Abstract/Plugin/ExtraClauses.pm line 126, near "},"
syntax error at /Volumes/Vault/david/git-repos/sql-abstract/blib/lib/SQL/Abstract/Plugin/ExtraClauses.pm line 128, near "}"
Compilation failed in require at /Volumes/Vault/david/git-repos/sql-abstract/blib/lib/SQL/Abstract.pm line 394.
t/80extra_clauses.t ....... Dubious, test returned 9 (wstat 2304, 0x900)

This trivial patch fixes it.

@coveralls
Copy link

coveralls commented Feb 24, 2021

Pull Request Test Coverage Report for Build 75

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 80.885%

Totals Coverage Status
Change from base Build 73: 0.08%
Covered Lines: 1024
Relevant Lines: 1266

💛 - Coveralls

@ilmari
Copy link
Member

ilmari commented May 19, 2021

Sorry, I didn't see this PR, but I fixed it myself directly in master with commit c5dd2e6.

@ilmari ilmari closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants