From 8d3d33c48c84252aed01b3289527c25a27d735ca Mon Sep 17 00:00:00 2001
From: Larry Leszczynski <larryl@cpan.org>
Date: Tue, 18 May 2021 10:30:40 -0600
Subject: [PATCH] Speed up check for illegal top-level op

Calling List::Util::first here keeps showing up as a hotspot on our NYTProf output, so just use a regex instead.
---
 lib/SQL/Abstract.pm | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/SQL/Abstract.pm b/lib/SQL/Abstract.pm
index 97e3b196..e4910c8b 100644
--- a/lib/SQL/Abstract.pm
+++ b/lib/SQL/Abstract.pm
@@ -36,13 +36,14 @@ our $AUTOLOAD;
 
 # special operators (-in, -between). May be extended/overridden by user.
 # See section WHERE: BUILTIN SPECIAL OPERATORS below for implementation
-my @BUILTIN_SPECIAL_OPS = (
-  {regex => qr/^ (?: not \s )? between $/ix, handler => sub { die "NOPE" }},
-  {regex => qr/^ is (?: \s+ not )?     $/ix, handler => sub { die "NOPE" }},
-  {regex => qr/^ (?: not \s )? in      $/ix, handler => sub { die "NOPE" }},
-  {regex => qr/^ ident                 $/ix, handler => sub { die "NOPE" }},
-  {regex => qr/^ value                 $/ix, handler => sub { die "NOPE" }},
-);
+my $BUILTIN_SPECIAL_OPS_re = qr/
+    ^ (?:
+        (?: (?: not \s )? (?: between | in ) ) |
+        (?: is (?: \s+ not )?                ) |
+        ident |
+        value
+    ) $
+/ix;
 
 #======================================================================
 # DEBUGGING AND ERROR REPORTING
@@ -1109,7 +1110,7 @@ sub _expand_hashpair_op {
         $is_special
         or (
           $self->{disable_old_special_ops}
-          and List::Util::first { $wsop =~ $_->{regex} } @BUILTIN_SPECIAL_OPS
+          and $wsop =~ $BUILTIN_SPECIAL_OPS_re
         )
       )
     ) {